Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent NPE when calling ConsoleContentPanel.showMessage #1238

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: prevent NPE when calling ConsoleContentPanel.showMessage #1238

merged 1 commit into from
Oct 18, 2023
+6 −0

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Oct 18, 2023

Fixes rare NPE:

java.lang.NullPointerException: Cannot invoke “com.intellij.execution.ui.ConsoleView.print(String, com.intellij.execution.ui.ConsoleViewContentType)” because “this.consoleView” is null
	at com.redhat.devtools.intellij.lsp4ij.console.LSPConsoleToolWindowPanel$ConsoleContentPanel.showMessage(LSPConsoleToolWindowPanel.java:249)
[15:05](https://redhat-internal.slack.com/archives/DK4SDAQJH/p1697634348846939)

@fbricon fbricon self-assigned this Oct 18, 2023
@fbricon fbricon added the bug Something isn't working label Oct 18, 2023
@fbricon fbricon added this to the 1.29.0 milestone Oct 18, 2023
@fbricon fbricon added the lsp4ij LSP client for IJ label Oct 18, 2023
@fbricon fbricon changed the title fix : prevent NPE when calling ConsoleContentPanel.showMessage fix: prevent NPE when calling ConsoleContentPanel.showMessage Oct 18, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.0% 13.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@fbricon fbricon merged commit 30a70eb into redhat-developer:main Oct 18, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fbricon fbricon

Labels
bug Something isn't working lsp4ij LSP client for IJ
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
1 participant
@fbricon